hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
Date Mon, 16 Dec 2013 17:07:08 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849338#comment-13849338
] 

Andrew Wang commented on HDFS-5665:
-----------------------------------

These test failures look spurious to me. +1, thanks Uma!

> Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-5665
>                 URL: https://issues.apache.org/jira/browse/HDFS-5665
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
>  writeLock();
>       try {
>         this.cacheManager = new CacheManager(this, conf, blockManager);
>       } finally {
>         writeUnlock();
>       }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a clear reason
to keep the lock.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message