hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5592) "DIR* completeFile: /file is closed by DFSClient_" should be logged only for successful closure of the file.
Date Tue, 03 Dec 2013 12:20:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837630#comment-13837630
] 

Hadoop QA commented on HDFS-5592:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12616735/HDFS-5592.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//console

This message is automatically generated.

> "DIR* completeFile: /file is closed by DFSClient_" should be logged only for successful
closure of the file.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5592
>                 URL: https://issues.apache.org/jira/browse/HDFS-5592
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Vinay
>            Assignee: Vinay
>         Attachments: HDFS-5592.patch
>
>
> Following log message in {{FSNameSystem#completeFile(..)}} should be logged only if the
file is closed.
> {code}    getEditLog().logSync();
>     NameNode.stateChangeLog.info("DIR* completeFile: " + src + " is closed by "
>         + holder);
>     return success;{code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message