hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5582) hdfs getconf -excludeFile or -includeFile always failed
Date Mon, 02 Dec 2013 08:24:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836353#comment-13836353
] 

Hadoop QA commented on HDFS-5582:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12616505/00001-HDFS-5582.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5606//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5606//console

This message is automatically generated.

> hdfs getconf -excludeFile or -includeFile always failed
> -------------------------------------------------------
>
>                 Key: HDFS-5582
>                 URL: https://issues.apache.org/jira/browse/HDFS-5582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta, 2.2.0
>            Reporter: Henry Hung
>            Priority: Minor
>         Attachments: 00001-HDFS-5582.patch
>
>
> In hadoop-2.2.0, if you execute getconf for exclude and include file, it will return
this error message:
> {code}
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -excludeFile
> Configuration DFSConfigKeys.DFS_HOSTS_EXCLUDE is missing.
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -includeFile
> Configuration DFSConfigKeys.DFS_HOSTS is missing.
> {code}
> I found out the root cause is very simple, it’s because the source code of {{org/apache/hadoop/hdfs/tools/GetConf.java}}
hard coded it to {{"DFSConfigKeys.DFS_HOSTS"}} and {{"DFSConfigKeys.DFS_HOSTS_EXCLUDE"}}
> {code}
>       map.put(INCLUDE_FILE.getName().toLowerCase(), 
>           new CommandHandler("DFSConfigKeys.DFS_HOSTS"));
>       map.put(EXCLUDE_FILE.getName().toLowerCase(),
>           new CommandHandler("DFSConfigKeys.DFS_HOSTS_EXCLUDE"));
> {code}
> A simple fix would be to remove the quote:
> {code}
>       map.put(INCLUDE_FILE.getName().toLowerCase(), 
>           new CommandHandler(DFSConfigKeys.DFS_HOSTS));
>       map.put(EXCLUDE_FILE.getName().toLowerCase(),
>           new CommandHandler(DFSConfigKeys.DFS_HOSTS_EXCLUDE));
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message