hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sathish (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5582) hdfs getconf -excludeFile or -includeFile always failed
Date Thu, 26 Dec 2013 05:32:52 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

sathish updated HDFS-5582:
--------------------------

    Attachment: 0002-HDFS-5582.patch

Thanks Andrew wang for having a look,updating the patch as per the comments with unit test
case

> hdfs getconf -excludeFile or -includeFile always failed
> -------------------------------------------------------
>
>                 Key: HDFS-5582
>                 URL: https://issues.apache.org/jira/browse/HDFS-5582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta, 2.2.0, 2.3.0
>            Reporter: Henry Hung
>            Assignee: sathish
>            Priority: Minor
>         Attachments: 00001-HDFS-5582.patch, 0002-HDFS-5582.patch
>
>
> In hadoop-2.2.0, if you execute getconf for exclude and include file, it will return
this error message:
> {code}
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -excludeFile
> Configuration DFSConfigKeys.DFS_HOSTS_EXCLUDE is missing.
> [hadoop@fphd1 hadoop-2.2.0]$ bin/hdfs getconf -includeFile
> Configuration DFSConfigKeys.DFS_HOSTS is missing.
> {code}
> I found out the root cause is very simple, it’s because the source code of {{org/apache/hadoop/hdfs/tools/GetConf.java}}
hard coded it to {{"DFSConfigKeys.DFS_HOSTS"}} and {{"DFSConfigKeys.DFS_HOSTS_EXCLUDE"}}
> {code}
>       map.put(INCLUDE_FILE.getName().toLowerCase(), 
>           new CommandHandler("DFSConfigKeys.DFS_HOSTS"));
>       map.put(EXCLUDE_FILE.getName().toLowerCase(),
>           new CommandHandler("DFSConfigKeys.DFS_HOSTS_EXCLUDE"));
> {code}
> A simple fix would be to remove the quote:
> {code}
>       map.put(INCLUDE_FILE.getName().toLowerCase(), 
>           new CommandHandler(DFSConfigKeys.DFS_HOSTS));
>       map.put(EXCLUDE_FILE.getName().toLowerCase(),
>           new CommandHandler(DFSConfigKeys.DFS_HOSTS_EXCLUDE));
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message