hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5581) NameNodeFsck should use only one instance of BlockPlacementPolicy
Date Mon, 02 Dec 2013 16:37:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836668#comment-13836668
] 

Hudson commented on HDFS-5581:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #4810 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4810/])
HDFS-5581. NameNodeFsck should use only one instance of BlockPlacementPolicy (vinay via cmccabe)
(cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547088)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java


> NameNodeFsck should use only one instance of BlockPlacementPolicy
> -----------------------------------------------------------------
>
>                 Key: HDFS-5581
>                 URL: https://issues.apache.org/jira/browse/HDFS-5581
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Vinay
>            Assignee: Vinay
>             Fix For: 2.2.1
>
>         Attachments: HDFS-5581.patch, HDFS-5581.patch
>
>
> While going through NameNodeFsck I found that following code creates the new instance
of BlockPlacementPolicy for every block.
> {code}      // verify block placement policy
>       BlockPlacementStatus blockPlacementStatus = 
>           BlockPlacementPolicy.getInstance(conf, null, networktopology).
>               verifyBlockPlacement(path, lBlk, targetFileReplication);{code}
> It would be better to use the namenode's BPP itself instead of creating a new one.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message