hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Binglin Chang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5574) Remove buffer copy in BlockReader.skip
Date Fri, 20 Dec 2013 00:25:08 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Binglin Chang updated HDFS-5574:
--------------------------------

    Attachment: HDFS-5574.v5.patch

Thanks for the review Colin. I updated the patch.

bq. I don't think you want this in TestRemoteBlockReader.
I set DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER to true, so getBlockReader can get RemoteBlockReader
rather than RemoteBlockReader2. 

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.v1.patch, HDFS-5574.v2.patch, HDFS-5574.v3.patch, HDFS-5574.v4.patch,
HDFS-5574.v5.patch
>
>
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read data to this
buffer, it is not necessary. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message