hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5574) Remove buffer copy in BlockReader.skip
Date Thu, 19 Dec 2013 20:45:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853282#comment-13853282
] 

Colin Patrick McCabe commented on HDFS-5574:
--------------------------------------------

Thanks for working on this, Binglin.

{code}
  BlockReaderTestUtil util;
  byte[] blockData;
  BlockReader reader;
{code}
If these aren't needed by the test subclasses, they should be private.  Similarly with {{getBlockReader}}.

{code}
    conf.setBoolean(DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER, true);
{code}
I don't think you want this in {{TestRemoteBlockReader}}.

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.v1.patch, HDFS-5574.v2.patch, HDFS-5574.v3.patch, HDFS-5574.v4.patch
>
>
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read data to this
buffer, it is not necessary. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message