hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Binglin Chang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5574) Remove buffer copy in BlockReader.skip
Date Wed, 18 Dec 2013 04:08:07 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Binglin Chang updated HDFS-5574:

    Attachment: HDFS-5574.v3.patch

Thanks for the comments, Colin. The new v3 patch just remove changes of BlockReaderLocal in
v2 patch. Since RemoteBlockReader is deprecated, I keep it unchanged. 
Another change is add synchronized to RemoteBlockReader2.read(ByteBuffer buf),  there is a
findbug warning.
Add a test to test DFSInpustream.skip which will call BlockReader.skip. 

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.v1.patch, HDFS-5574.v2.patch, HDFS-5574.v3.patch
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read data to this
buffer, it is not necessary. 

This message was sent by Atlassian JIRA

View raw message