Return-Path: 
 <hdfs-issues-return-72426-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6E8E1106EC
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Wed, 20 Nov 2013 00:27:27 +0000 (UTC)
Received: (qmail 98120 invoked by uid 500); 20 Nov 2013 00:27:26 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 98075 invoked by uid 500); 20 Nov 2013 00:27:26 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 98041 invoked by uid 99); 20 Nov 2013 00:27:26 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2013 00:27:26 +0000
Date: Wed, 20 Nov 2013 00:27:26 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12679151.1384406043733.102733.1384907246804@arcas>
In-Reply-To: <JIRA.12679151.1384406043733@arcas>
References: <JIRA.12679151.1384406043733@arcas>
Subject: [jira] [Commented] (HDFS-5513) CacheAdmin commands fail when using
 . as the path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827176#comment-13827176 ] 

Andrew Wang commented on HDFS-5513:
-----------------------------------

With Jenkins clean, will commit this shortly based on Colin's earlier +1. Thanks again for the review.

> CacheAdmin commands fail when using . as the path
> -------------------------------------------------
>
>                 Key: HDFS-5513
>                 URL: https://issues.apache.org/jira/browse/HDFS-5513
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: caching, tools
>    Affects Versions: 3.0.0
>            Reporter: Stephen Chu
>            Assignee: Andrew Wang
>            Priority: Minor
>         Attachments: hdfs-5513-1.patch, hdfs-5513-2.patch, hdfs-5513-3.patch
>
>
> The hdfs CLI commands generally accept "." as a path argument.
> e.g.
> {code}
> hdfs dfs -rm .
> hdfs dfsadmin -allowSnapshot .
> {code}
> I don't think it's very common to use the path "." but the CacheAdmin commands will fail saying that it cannot create a Path from an empty string.
> {code}
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -removeDirectives -path .
> Exception in thread "main" java.lang.IllegalArgumentException: Can not create a Path from an empty string
> 	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:184)
> 	at org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem.listPathBasedCacheDirectives(DistributedFileSystem.java:1639)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin$RemovePathBasedCacheDirectivesCommand.run(CacheAdmin.java:365)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -addDirective -path . -pool schu
> Exception in thread "main" java.lang.IllegalArgumentException: Can not create a Path from an empty string
> 	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
> 	at org.apache.hadoop.fs.Path.<init>(Path.java:184)
> 	at org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66)
> 	at org.apache.hadoop.hdfs.DistributedFileSystem.addPathBasedCacheDirective(DistributedFileSystem.java:1598)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin$AddPathBasedCacheDirectiveCommand.run(CacheAdmin.java:180)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)