Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 5 Nov 2013 09:00:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12677472.1383608044311.21746.1383642027728@arcas>
In-Reply-To: <JIRA.12677472.1383608044311@arcas>
References: <JIRA.12677472.1383608044311@arcas>
Subject: [jira] [Commented] (HDFS-5458) Datanode failed volume threshold
 ignored if exception is thrown in getDataDirsFromURIs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813782#comment-13813782 ] 

Hadoop QA commented on HDFS-5458:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612086/HDFS-5458-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5335//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5335//console

This message is automatically generated.

> Datanode failed volume threshold ignored if exception is thrown in getDataDirsFromURIs
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-5458
>                 URL: https://issues.apache.org/jira/browse/HDFS-5458
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Mike Mellenthin
>         Attachments: HDFS-5458-1.patch
>
>
> Saw a stacktrace of datanode startup with a bad volume, where even listing directories would throw an IOException. The failed volume threshold was set to 1, but it would fatally error out in {{File#getCanonicalPath}} in {{getDataDirsFromURIs}}:
> {code}
>       File dir = new File(dirURI.getPath());
>       try {
>         dataNodeDiskChecker.checkDir(localFS, new Path(dir.toURI()));
>         dirs.add(dir);
>       } catch (IOException ioe) {
>         LOG.warn("Invalid " + DFS_DATANODE_DATA_DIR_KEY + " "
>             + dir + " : ", ioe);
>         invalidDirs.append("\"").append(dir.getCanonicalPath()).append("\" ");
>       }
> {code}
> Since {{getCanonicalPath}} can need to do I/O and thus throw an IOException, this catch clause doesn't properly protect startup from a failed volume.


--
This message was sent by Atlassian JIRA
(v6.1#6144)