Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33C641052E for ; Wed, 20 Nov 2013 16:39:41 +0000 (UTC) Received: (qmail 92024 invoked by uid 500); 20 Nov 2013 16:39:37 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 91973 invoked by uid 500); 20 Nov 2013 16:39:37 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 91948 invoked by uid 99); 20 Nov 2013 16:39:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2013 16:39:36 +0000 Date: Wed, 20 Nov 2013 16:39:36 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5014) BPOfferService#processCommandFromActor() synchronization on namenode RPC call delays IBR to Active NN, if Stanby NN is unstable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827824#comment-13827824 ] Hudson commented on HDFS-5014: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #4768 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4768/]) HDFS-5014. Process register commands with out holding BPOfferService lock. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1543861) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java > BPOfferService#processCommandFromActor() synchronization on namenode RPC call delays IBR to Active NN, if Stanby NN is unstable > ------------------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-5014 > URL: https://issues.apache.org/jira/browse/HDFS-5014 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode, ha > Affects Versions: 3.0.0, 2.0.4-alpha > Reporter: Vinay > Assignee: Vinay > Attachments: HDFS-5014-v2.patch, HDFS-5014-v2.patch, HDFS-5014-v2.patch, HDFS-5014-v2.patch, HDFS-5014-v2.patch, HDFS-5014-v2.patch, HDFS-5014.patch, HDFS-5014.patch, HDFS-5014.patch, HDFS-5014.patch, HDFS-5014.patch, HDFS-5014.patch, HDFS-5014.patch > > > In one of our cluster, following has happened which failed HDFS write. > 1. Standby NN was unstable and continously restarting due to some errors. But Active NN was stable. > 2. MR Job was writing files. > 3. At some point SNN went down again while datanode processing the REGISTER command for SNN. > 4. Datanodes started retrying to connect to SNN to register at the following code in BPServiceActor#retrieveNamespaceInfo() which will be called under synchronization. > {code} try { > nsInfo = bpNamenode.versionRequest(); > LOG.debug(this + " received versionRequest response: " + nsInfo); > break;{code} > Unfortunately in all datanodes at same point this happened. > 5. For next 7-8 min standby was down, and no blocks were reported to active NN at this point and writes have failed. > So culprit is {{BPOfferService#processCommandFromActor()}} is completely synchronized which is not required. -- This message was sent by Atlassian JIRA (v6.1#6144)