hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fengdong Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5561) FSNameSystem#getNameJournalStatus() in JMX should return plain text instead of HTML
Date Tue, 26 Nov 2013 03:41:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832277#comment-13832277
] 

Fengdong Yu commented on HDFS-5561:
-----------------------------------

I tested. It works well. 

but I have a minor comments:

/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/AsyncLoggerSet.java
{code}
+  void appendReport(StringBuilder sb) {
+    for (int i = 0, len = loggers.size(); i < len; ++i) {
{code}

It  can be simplified:
{code}
for(int i = 0; i < loggers.size(); ++i) {
{code}

> FSNameSystem#getNameJournalStatus() in JMX should return plain text instead of HTML
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-5561
>                 URL: https://issues.apache.org/jira/browse/HDFS-5561
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Fengdong Yu
>            Assignee: Haohui Mai
>            Priority: Minor
>         Attachments: HDFS-5561.000.patch, NNUI.PNG
>
>
> Currently FSNameSystem#getNameJournalStatus() returns the status of the quorum stream,
which is an HTML string. This should not happen since that getNameJournalStatus() is a JMX
call. This will confuse the downstream clients (e.g., the web UI) and lead to incorrect result.
> This jira proposes to change the information to plain text.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message