hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kihwal Lee (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5557) Write pipeline recovery for the last packet in the block may cause rejection of valid replicas
Date Sat, 23 Nov 2013 01:55:35 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kihwal Lee updated HDFS-5557:
-----------------------------

    Attachment: HDFS-5557.patch

The patch modifies {{BlockManager.addStoredBlockUnderConstruction()}} to update {{BlockInfoUnderContruction}}
with the reported block, not the stored block itself.

In this method, the old behavior is restored if {{ucBlock.storedBlock}} is used instead of
{{ucBlock.reportedBlock}}. The unit test will fail with the old behavior.

An incorrect assertion is removed from {{DFSOutputStream}}. The assertion is only correct
if the block is the last block. If there is more data to be written beyond this block, it
fails.

> Write pipeline recovery for the last packet in the block may cause rejection of valid
replicas
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5557
>                 URL: https://issues.apache.org/jira/browse/HDFS-5557
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.9, 2.3.0
>            Reporter: Kihwal Lee
>            Priority: Critical
>         Attachments: HDFS-5557.patch
>
>
> When a block is reported from a data node while the block is under construction (i.e.
not committed or completed), BlockManager calls BlockInfoUnderConstruction.addReplicaIfNotPresent()
to update the reported replica state. But BlockManager is calling it with the stored block,
not reported block.  This causes the recorded replicas' gen stamp to be that of BlockInfoUnderConstruction
itself, not the one from reported replica.
> When a pipeline recovery is done for the last packet of a block, the incremental block
reports with the new gen stamp may come before the client calling updatePipeline(). If this
happens, these replicas will be incorrectly recorded with the old gen stamp and get removed
later.  The result is close or addAdditionalBlock failure.
> If the last block is completed, but the penultimate block is not because of this issue,
the file won't be closed. If this file is not cleared, but the client goes away, the lease
manager will try to recover the lease/block, at which point it will crash. I will file a separate
jira for this shortly.
> The worst case is to reject all good ones and accepting a bad one. In this case, the
block will get completed, but the data cannot be read until the next full block report containing
one of the valid replicas is received.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message