hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5542) Fix TODO and clean up the code in HDFS-2832.
Date Fri, 22 Nov 2013 18:34:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830205#comment-13830205
] 

Arpit Agarwal commented on HDFS-5542:
-------------------------------------

Thanks for the patch Nicholas!

Looks like it causes a compile error in Datanode.java
{code}
[ERROR] /Users/aagarwal/src/hdp2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:[309,8]
cannot find symbol
symbol  : variable DFS_MAX_NUM_BLOCKS_TO_LOG_DEFAULT
{code}

Would it just be simpler to have the following like in trunk, instead of importing individual
keys? I am not sure if some of the imports cleanup was intentional or done by Eclipse.
{code}
import static org.apache.hadoop.hdfs.DFSConfigKeys.*;
{code}

Changes look good otherwise.


> Fix TODO and clean up the code in HDFS-2832.
> --------------------------------------------
>
>                 Key: HDFS-5542
>                 URL: https://issues.apache.org/jira/browse/HDFS-5542
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h5542_20131121.patch
>
>
> - Fix TODOs.
> - Remove unused code.
> - Reduce visibility (e.g. change public to package private.)
> - Simplify the code if possible.
> - Fix comments and javadoc.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message