hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5514) FSNamesystem's fsLock should allow custom implementation
Date Fri, 15 Nov 2013 04:11:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823259#comment-13823259
] 

Jonathan Eagles commented on HDFS-5514:
---------------------------------------

Hi, Daryn. I like what is going on here. One minor nit in addition to the above feedback.
Please remove the unnecessary _import java.util.concurrent.locks.ReadWriteLock_ in TestFSNamesystem.java

> FSNamesystem's fsLock should allow custom implementation
> --------------------------------------------------------
>
>                 Key: HDFS-5514
>                 URL: https://issues.apache.org/jira/browse/HDFS-5514
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-5514.patch
>
>
> Changing {{fsLock}} from a {{ReentrantReadWriteLock}} to an API compatible class that
encapsulates the rwLock will allow for more sophisticated locking implementations such as
fine grain locking.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message