hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5512) CacheAdmin -listPools fails with NPE when user lacks permissions to view all pools
Date Mon, 18 Nov 2013 22:59:21 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HDFS-5512:
------------------------------

    Attachment: hdfs-5512-1.patch

Small patch attached. This one is hard to unit test due to how our shell command testing works,
we can't easily use a proxy user. I tested manually though as follows:

{code}
-> % hdfs cacheadmin -listPools                                  
Found 2 results.
NAME   OWNER   GROUP   MODE       WEIGHT 
pool1  andrew  andrew  rwx------  100    
pool2  andrew  andrew  rwxr-xr-x  100   

..become root...

-> # hdfs cacheadmin -listPools
Found 2 results.
NAME   OWNER   GROUP   MODE       WEIGHT 
pool1                                    
pool2  andrew  andrew  rwxr-xr-x  100    
{code}

> CacheAdmin -listPools fails with NPE when user lacks permissions to view all pools
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-5512
>                 URL: https://issues.apache.org/jira/browse/HDFS-5512
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 3.0.0
>            Reporter: Stephen Chu
>            Assignee: Andrew Wang
>         Attachments: hdfs-5512-1.patch
>
>
> https://issues.apache.org/jira/browse/HDFS-5471 (CacheAdmin -listPools fails when user
lacks permissions to view all pools) was recently resolved, but on a build with this fix,
I am running into another error when using cacheadmin -listPools.
> Now, when the user does not have permissions to view all the pools, the cacheadmin -listPools
command will throw a NullPointerException.
> On a system with a single pool "root" with a mode of 750, I see this as user schu:
> {code}
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -listPools
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin$ListCachePoolsCommand.run(CacheAdmin.java:745)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
> 	at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)
> {code}
> After we modify the root pool to 755, then -listPools works properly.
> {code}
> [schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -listPools
> Found 1 result.
> NAME  OWNER  GROUP  MODE       WEIGHT 
> root  root   root   rwxr-xr-x  100    
> [schu@hdfs-c5-nfs ~]$ 
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message