hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5511) improve CacheManipulator interface to allow better unit testing
Date Wed, 13 Nov 2013 22:39:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821930#comment-13821930
] 

Hadoop QA commented on HDFS-5511:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12613671/HDFS-5511.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 eclipse:eclipse{color}.  The patch failed to build with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5423//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5423//console

This message is automatically generated.

> improve CacheManipulator interface to allow better unit testing
> ---------------------------------------------------------------
>
>                 Key: HDFS-5511
>                 URL: https://issues.apache.org/jira/browse/HDFS-5511
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5511.001.patch
>
>
> The CacheManipulator interface has been helpful in allowing us to stub out {{mlock}}
in cases where we don't want to test it.  We should move  the {{getMemlockLimit}} and {{getOperatingSystemPageSize}}
functions into this interface as well so that we don't have to skip these tests on machines
where these methods would ordinarily not work for us.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message