hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5511) improve CacheManipulator interface to allow better unit testing
Date Tue, 19 Nov 2013 20:23:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826903#comment-13826903

Colin Patrick McCabe commented on HDFS-5511:

Findbugs warnings are HADOOP-10116, not related to this change.  Will commit shortly based
on Andrew's +1.

> improve CacheManipulator interface to allow better unit testing
> ---------------------------------------------------------------
>                 Key: HDFS-5511
>                 URL: https://issues.apache.org/jira/browse/HDFS-5511
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5511.001.patch, HDFS-5511.002.patch
> The CacheManipulator interface has been helpful in allowing us to stub out {{mlock}}
in cases where we don't want to test it.  We should move  the {{getMemlockLimit}} and {{getOperatingSystemPageSize}}
functions into this interface as well so that we don't have to skip these tests on machines
where these methods would ordinarily not work for us.

This message was sent by Atlassian JIRA

View raw message