hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5474) Deletesnapshot can make Namenode in safemode on NN restarts.
Date Wed, 13 Nov 2013 08:14:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821049#comment-13821049
] 

Hadoop QA commented on HDFS-5474:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12613492/HDFS-5474-002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5417//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5417//console

This message is automatically generated.

> Deletesnapshot can make Namenode in safemode on NN restarts.
> ------------------------------------------------------------
>
>                 Key: HDFS-5474
>                 URL: https://issues.apache.org/jira/browse/HDFS-5474
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>            Reporter: Uma Maheswara Rao G
>            Assignee: sathish
>         Attachments: HDFS-5474-001.patch, HDFS-5474-002.patch
>
>
> When we deletesnapshot, we are deleting the blocks associated to that snapshot and after
that we do logsync to editlog about deleteSnapshot.
> There can be a chance that blocks removed from blocks map but before log sync if there
is BR ,  NN may finds that block does not exist in blocks map and may invalidate that block.
As part HB, invalidation info also can go. After this steps if Namenode shutdown before actually
do logsync,  On restart it will still consider that snapshot Inodes and expect blocks to report
from DN.
> Simple solution is, we should simply move down that blocks removal after logsync only.
Similar to delete op.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message