hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5456) NameNode startup progress creates new steps if caller attempts to create a counter for a step that doesn't already exist.
Date Tue, 05 Nov 2013 00:42:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813476#comment-13813476
] 

Hadoop QA commented on HDFS-5456:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612044/HDFS-5456.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5329//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5329//console

This message is automatically generated.

> NameNode startup progress creates new steps if caller attempts to create a counter for
a step that doesn't already exist.
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5456
>                 URL: https://issues.apache.org/jira/browse/HDFS-5456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Critical
>         Attachments: HDFS-5456.1.patch
>
>
> NameNode startup progress is supposed to be immutable after startup has completed.  All
methods are coded to ignore update attempts after startup has completed.  However, {{StartupProgress#getCounter}}
does not implement this correctly.  If a caller attempts to get a counter for a new step that
hasn't been seen before, then the method accidentally creates the step.  This allocates additional
space in the internal tracking data structures, so ultimately this is a memory leak.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message