hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5355) Hsync Metrics error
Date Mon, 18 Nov 2013 17:39:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825515#comment-13825515
] 

Andrew Wang commented on HDFS-5355:
-----------------------------------

Hey folks, I think this is a case where the comment is wrong but the code is basically right.
Although poorly named and documented, right now we're using these metrics to track two different
things: the # of "logical" syncs e.g. via hsync, and the # of actual fsyncs via {{#force}}.
Changing this would be a little incompatible.

> Hsync Metrics error
> -------------------
>
>                 Key: HDFS-5355
>                 URL: https://issues.apache.org/jira/browse/HDFS-5355
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: haosdent
>            Priority: Minor
>         Attachments: HDFS-5355.patch
>
>
> The authors before comment "Expect two syncs, one from the hsync, one on close" in TestDataNodeMetrics.java.
In fact there isn't call sync when close. One hsync call would produce two syncs, one for
checksum and the other for block. I modify relate code and make it looks like the hflush metrics.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message