hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5355) Hsync Metrics error
Date Sun, 17 Nov 2013 17:03:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824899#comment-13824899
] 

Uma Maheswara Rao G commented on HDFS-5355:
-------------------------------------------

Thanks for filing JIRA and working on it
Make sense to me for making this same as flush metrics. I think, we need not expose sync metrics
for 2 i.e checksum file and blockfile. We can add them into one as you proposed. I am not
sure if there is a real reason to do so. 
I think, BlockReceiver#close also has similar issue?

{code}
  datanode.metrics.incrFsyncCount();
+        datanode.metrics.addFsyncNanos(fsyncTotalNanos);
{code}
Please follow hadoop formater. Indentation should be 2 spaces.

.




> Hsync Metrics error
> -------------------
>
>                 Key: HDFS-5355
>                 URL: https://issues.apache.org/jira/browse/HDFS-5355
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: haosdent
>            Priority: Minor
>         Attachments: HDFS-5355.patch
>
>
> The authors before comment "Expect two syncs, one from the hsync, one on close" in TestDataNodeMetrics.java.
In fact there isn't call sync when close. One hsync call would produce two syncs, one for
checksum and the other for block. I modify relate code and make it looks like the hflush metrics.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message