hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5326) add modifyDirective to cacheAdmin
Date Thu, 07 Nov 2013 02:55:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815585#comment-13815585
] 

Colin Patrick McCabe commented on HDFS-5326:
--------------------------------------------

bq. This wasn't addressed, could you mind shuffling this around? I guess redoing the opcodes
is optional (though appreciated), but I'd like to see all the methods/cases organized.

I reordered the opcodes.  I suppose it does make sense to do.

bq. I took a hack at this and it ended up being less code and IMO cleaner. I can do this in
a follow-on if you like, but:

Let's do this as part of HDFS-5471 if it looks good... similarly with refactoring pc#checkPermission.

bq. need to add a space

fixed

bq. Unrelated, but I noticed that CacheManager#listPBCDs does a pc check without first checking
if pc is null, want to fix that here?

fxied

> add modifyDirective to cacheAdmin
> ---------------------------------
>
>                 Key: HDFS-5326
>                 URL: https://issues.apache.org/jira/browse/HDFS-5326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5326.003.patch, HDFS-5326.004.patch, HDFS-5326.006.patch, HDFS-5326.007.patch
>
>
> We should add a way of modifying cache directives on the command-line, similar to how
modifyCachePool works.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message