Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 14 Oct 2013 10:27:42 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12673654.1381738278240.59454.1381746462880@arcas>
In-Reply-To: <JIRA.12673654.1381738278240@arcas>
References: <JIRA.12673654.1381738278240@arcas>
Subject: [jira] [Commented] (HDFS-5355) Hsync Metrics error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794035#comment-13794035 ] 

Hadoop QA commented on HDFS-5355:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12608253/HDFS-5355.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5180//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5180//console

This message is automatically generated.

> Hsync Metrics error
> -------------------
>
>                 Key: HDFS-5355
>                 URL: https://issues.apache.org/jira/browse/HDFS-5355
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: haosdent
>            Priority: Minor
>         Attachments: HDFS-5355.patch
>
>
> The authors before comment "Expect two syncs, one from the hsync, one on close" in TestDataNodeMetrics.java. In fact there isn't call sync when close. One hsync call would produce two syncs, one for checksum and the other for block. I modify relate code and make it looks like the hflush metrics.


--
This message was sent by Atlassian JIRA
(v6.1#6144)