Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8EE5610176 for ; Mon, 7 Oct 2013 00:45:42 +0000 (UTC) Received: (qmail 25285 invoked by uid 500); 7 Oct 2013 00:45:42 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 25211 invoked by uid 500); 7 Oct 2013 00:45:42 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 25050 invoked by uid 99); 7 Oct 2013 00:45:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Oct 2013 00:45:42 +0000 Date: Mon, 7 Oct 2013 00:45:42 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work started] (HDFS-5314) Do not expose CachePool type in AddCachePoolOp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HDFS-5314 started by Colin Patrick McCabe. > Do not expose CachePool type in AddCachePoolOp > ---------------------------------------------- > > Key: HDFS-5314 > URL: https://issues.apache.org/jira/browse/HDFS-5314 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Affects Versions: HDFS-4949 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-5314-caching.001.patch > > > {{CachePool}} is an internal type which should not be exposed or used in the {{FSEditLog}}. Because {{CachePool}} is mutable, storing a reference to it in an edit log operation could lead to the edit log operation changing as a result of the {{CachePool}} object being changed. Instead, we should store {{CachePoolInfo}}. -- This message was sent by Atlassian JIRA (v6.1#6144)