Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BA9010FF7 for ; Mon, 7 Oct 2013 20:50:45 +0000 (UTC) Received: (qmail 95365 invoked by uid 500); 7 Oct 2013 20:50:43 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 95297 invoked by uid 500); 7 Oct 2013 20:50:43 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 95271 invoked by uid 99); 7 Oct 2013 20:50:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Oct 2013 20:50:42 +0000 Date: Mon, 7 Oct 2013 20:50:42 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5224) Refactor PathBasedCache* methods to use a Path rather than a String MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788552#comment-13788552 ] Colin Patrick McCabe commented on HDFS-5224: -------------------------------------------- er, wait, I think I misunderstood Chris's proposal. No, I am *not* saying we add {{Path}} to {{PathBasedCacheEntry}}. I'm saying we add a method in {{DistributedFileSystem}} that takes a {{Path}} and returns a {{PathBasedCacheEntry}} initialized with the correct {{String}} (or a builder initialized with the correct string) > Refactor PathBasedCache* methods to use a Path rather than a String > ------------------------------------------------------------------- > > Key: HDFS-5224 > URL: https://issues.apache.org/jira/browse/HDFS-5224 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: HDFS-4949 > Reporter: Andrew Wang > Assignee: Chris Nauroth > Attachments: HDFS-5224.1.patch > > > As discussed in HDFS-5213, we should refactor PathBasedCacheDirective and related methods in DistributedFileSystem to use a Path to represent paths to cache, rather than a String. -- This message was sent by Atlassian JIRA (v6.1#6144)