hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5363) Create SPENGO-authenticated connection in URLConnectionFactory instead of WebHdfsFileSystem
Date Mon, 21 Oct 2013 23:18:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801299#comment-13801299
] 

Jing Zhao commented on HDFS-5363:
---------------------------------

The patch looks good to me. Some minor comments:
# Let's keep the log "LOG.debug("open AuthenticatedURL connection");" and "LOG.debug("open
URL connection");"
# URLConnectionFactory#setTimeouts(URLConnection, int) can be declared as private? And please
update its javadoc. Or it can be merged into connConfigurator#configure.


> Create SPENGO-authenticated connection in URLConnectionFactory instead of WebHdfsFileSystem
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5363
>                 URL: https://issues.apache.org/jira/browse/HDFS-5363
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5363.000.patch, HDFS-5363.001.patch, HDFS-5363.002.patch, HDFS-5363.003.patch
>
>
> Currently the WebHdfsSystem class creates the http connection of urls that require SPENGO
authentication. This patch moves the above logic to URLConnectionFactory, which is the factory
class that supposes to create all http connection of WebHdfs client.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message