hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5349) DNA_CACHE and DNA_UNCACHE should be by blockId only
Date Mon, 14 Oct 2013 20:43:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794457#comment-13794457
] 

Andrew Wang commented on HDFS-5349:
-----------------------------------

Great, looks good. +1, up to you on the following:

* I think this is getting cleaned up in HDFS-5096, but In DatanodeManager, it'll be nice to
make forming the list of blockIds into a method.
* In {{BPOfferService}}, might be more clear to have a separate switch for {{BlockIdCommand}}.

Thanks for going through and updating all the javadoc too.

> DNA_CACHE and DNA_UNCACHE should be by blockId only 
> ----------------------------------------------------
>
>                 Key: HDFS-5349
>                 URL: https://issues.apache.org/jira/browse/HDFS-5349
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5349-caching.001.patch, HDFS-5349-caching.002.patch
>
>
> DNA_CACHE and DNA_UNCACHE should be by blockId only.  We don't need length and genstamp
to know what the NN asked us to cache.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message