hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5330) fix readdir and readdirplus for large directories
Date Tue, 15 Oct 2013 18:14:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795456#comment-13795456

Brandon Li commented on HDFS-5330:

Thank you, Jing.
{quote}Entry3#getFileId, Entry3#getCookie, and DirListPlus3#getEof may not need to be declared
as public. Please add @VisibleForTesting annotation to Entry3#getEntries, EntryPlus3#getEntries,
and EntryPlus3#getName.{quote}
{quote}The following code appears more than once in RpcProgrammNfs3, thus can be wrapped in
a separate method: ...{quote}
I tried to create a private method to share the retry logic but to find the code is much less
readable, and thus I kept it the same in the new patch.
{quote}The new unit test needs some javadoc.{quote}
{quote}It may be better to split testReaddirBasic into two separate unit tests: testReaddir
and testReaddirPlus..{quote}

> fix readdir and readdirplus for large directories
> -------------------------------------------------
>                 Key: HDFS-5330
>                 URL: https://issues.apache.org/jira/browse/HDFS-5330
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-5330.001.patch, HDFS-5330.002.patch, HDFS-5330.003.patch, HDFS-5330.004.patch
> These two calls need to use cookies to do multiple round trips to namenode to get the
complete list of the dirents. Currently implementation passes an inode path as "startAfter"
for listPath(), however, namenode doesn't resolve startAfter as an inode path. Better use
file name as "startAfter".

This message was sent by Atlassian JIRA

View raw message