hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5323) Remove some deadcode in BlockManager
Date Thu, 10 Oct 2013 11:01:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791381#comment-13791381
] 

Hudson commented on HDFS-5323:
------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #358 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/358/])
HDFS-5323.  Remove some deadcode in BlockManager (Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530814)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java


> Remove some deadcode in BlockManager
> ------------------------------------
>
>                 Key: HDFS-5323
>                 URL: https://issues.apache.org/jira/browse/HDFS-5323
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: HDFS-5323.001.patch
>
>
> {{BlockManager#DEFAULT_MAP_LOAD_FACTOR}} is deadcode.  It no longer does *anything* since
blocks are now stored in a GSet whose size is fixed.
> {{BlocksMap#blocks}} does not need to be volatile.  Whenever it is accessed, it is accessed
under the {{FSNamesystem}} lock.  Furthermore, access to this data structure is not thread-safe.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message