hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5323) Remove some deadcode in BlockManager
Date Wed, 09 Oct 2013 23:18:43 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Colin Patrick McCabe updated HDFS-5323:
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.0
           Status: Resolved  (was: Patch Available)

committed

> Remove some deadcode in BlockManager
> ------------------------------------
>
>                 Key: HDFS-5323
>                 URL: https://issues.apache.org/jira/browse/HDFS-5323
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: HDFS-5323.001.patch
>
>
> {{BlockManager#DEFAULT_MAP_LOAD_FACTOR}} is deadcode.  It no longer does *anything* since
blocks are now stored in a GSet whose size is fixed.
> {{BlocksMap#blocks}} does not need to be volatile.  Whenever it is accessed, it is accessed
under the {{FSNamesystem}} lock.  Furthermore, access to this data structure is not thread-safe.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message