hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5304) Expose if a block replica is cached in getFileBlockLocations
Date Wed, 09 Oct 2013 19:16:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790738#comment-13790738
] 

Colin Patrick McCabe commented on HDFS-5304:
--------------------------------------------

{code}
+    if (cachedLocs == null || cachedLocs.length == 0) {
+      this.cachedLocs = EMPTY_LOCS;
+    } else {
+      this.cachedLocs = cachedLocs;
+    }
{code}
Would advise not doing this, but just defaulting to EMPTY_LOCS rather than null.

+ 1 once that's addressed.

> Expose if a block replica is cached in getFileBlockLocations
> ------------------------------------------------------------
>
>                 Key: HDFS-5304
>                 URL: https://issues.apache.org/jira/browse/HDFS-5304
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS-4949
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-5304-1.patch, hdfs-5304-2.patch, hdfs-5304-3.patch
>
>
> We need to expose which replicas of a block are cached so applications can place their
tasks for memory-locality.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message