hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
Date Fri, 04 Oct 2013 17:58:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786418#comment-13786418
] 

Jing Zhao commented on HDFS-5300:
---------------------------------

Besides of the nit +1 for the patch.

> FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-5300
>                 URL: https://issues.apache.org/jira/browse/HDFS-5300
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Vinay
>            Assignee: Vinay
>         Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
> {code:java}      checkOperation(OperationCategory.WRITE);
>       if (isInSafeMode()) {
>         throw new SafeModeException(
>             "Cannot delete snapshot for " + snapshotRoot, safeMode);
>       }
>       FSPermissionChecker pc = getPermissionChecker();
>       checkOwner(pc, snapshotRoot);
>       BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
>       List<INode> removedINodes = new ChunkedArrayList<INode>();
>       dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all other operations.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message