hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility
Date Wed, 09 Oct 2013 21:12:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790860#comment-13790860
] 

Luke Lu commented on HDFS-5267:
-------------------------------

The patch lgtm. +1.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile
which cause wrong expectation on thread-safe visibility
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5267
>                 URL: https://issues.apache.org/jira/browse/HDFS-5267
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: HADOOP-9980.patch, HDFS-5267.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: LightWeightHashSet or
LightWeightLinkedSet) that is used to detect updates while iterating so they can throw a ConcurrentModificationException.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message