hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility
Date Sat, 05 Oct 2013 04:45:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786935#comment-13786935
] 

Hadoop QA commented on HDFS-5267:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12606960/HDFS-5267.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5105//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5105//console

This message is automatically generated.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile
which cause wrong expectation on thread-safe visibility
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5267
>                 URL: https://issues.apache.org/jira/browse/HDFS-5267
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>             Fix For: 2.3.0
>
>         Attachments: HADOOP-9980.patch, HDFS-5267.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: LightWeightHashSet or
LightWeightLinkedSet) that is used to detect updates while iterating so they can throw a ConcurrentModificationException.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message