hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5167) Add metrics about the NameNode retry cache
Date Fri, 18 Oct 2013 01:14:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798691#comment-13798691
] 

Jing Zhao commented on HDFS-5167:
---------------------------------

Thanks for the working on this Tsuyoshi! Some comments so far:

# Please add @InterfaceAudience.Private annotation to the new RetryCacheMetrics class.
# We need to clear the import section in RetryCacheMetrics
# The name of the RetryCache for FSNamesystem is "Namenode Retry Cache", this will make the
name used to register the metrics "RetryCacheNamenode Retry Cache". We should have some pre-processing
for the retrycache's name here.
# It may be better to put the retryMetrics instance inside the RetryCache and update the metrics
in RetryCache's methods, instead of declaring and updating it in FSNamesystem.

> Add metrics about the NameNode retry cache
> ------------------------------------------
>
>                 Key: HDFS-5167
>                 URL: https://issues.apache.org/jira/browse/HDFS-5167
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HDFS-5167.1.patch, HDFS-5167.2.patch, HDFS-5167.3.patch, HDFS-5167.4.patch,
HDFS-5167.5.patch
>
>
> It will be helpful to have metrics in NameNode about the retry cache, such as the retry
count etc.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message