hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5130) Add test for snapshot related FsShell and DFSAdmin commands
Date Mon, 14 Oct 2013 18:28:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794344#comment-13794344
] 

Jing Zhao commented on HDFS-5130:
---------------------------------

The patch looks good to me. Some minors:

# Please add some javadoc for TestSnapshotCommands and list commands that are tested.
# in toolRun(), we need to close out.
# It may be better to split the testSnapshotCommands method into multiple shorter tests, and
we only test one command in each test. This will also make it easier for us to add new test
cases in the future.

> Add test for snapshot related FsShell and DFSAdmin commands
> -----------------------------------------------------------
>
>                 Key: HDFS-5130
>                 URL: https://issues.apache.org/jira/browse/HDFS-5130
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>         Attachments: HDFS-5130.v1.patch, HDFS-5130.v2.patch
>
>
> Currently, those commands do not have tests which lead to some bugs recently. It's better
to add end-to-end tests for those commands.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message