hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy
Date Tue, 22 Oct 2013 00:14:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801342#comment-13801342
] 

Junping Du commented on HDFS-4885:
----------------------------------

Thanks Nicholas for review and comments! Yes. it seems to be abnormal for previous failure
and I agree we should track this until getting solid test failed log.
btw, do we think this JIRA to be part of HDFS-2832 or should go trunk instead?

> Update verifyBlockPlacement() API in BlockPlacementPolicy
> ---------------------------------------------------------
>
>                 Key: HDFS-4885
>                 URL: https://issues.apache.org/jira/browse/HDFS-4885
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Junping Du
>            Assignee: Junping Du
>              Labels: BlockPlacementPolicy
>             Fix For: Heterogeneous Storage (HDFS-2832)
>
>         Attachments: HDFS-4885.patch, HDFS-4885-v2.patch, HDFS-4885-v3.patch, HDFS-4885-v4.patch,
HDFS-4885-v5.1.patch, HDFS-4885-v5.patch
>
>
> verifyBlockPlacement() has unused parameter -srcPath as its responsibility just verify
single block rather than files under a specific path. Also the return value (int) does not
make sense as the violation of block placement has other case than number of racks, so boolean
value should be better.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message