Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A34C1002C for ; Thu, 26 Sep 2013 19:41:14 +0000 (UTC) Received: (qmail 97762 invoked by uid 500); 26 Sep 2013 19:41:04 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 97698 invoked by uid 500); 26 Sep 2013 19:41:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 97662 invoked by uid 99); 26 Sep 2013 19:41:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Sep 2013 19:41:03 +0000 Date: Thu, 26 Sep 2013 19:41:03 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-5266) ElasticByteBufferPool#Key does not implement equals. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HDFS-5266: -------------------------------- Attachment: HDFS-5266.1.patch This was found by Findbugs on the merge patch in HDFS-5260. Here is a patch that adds the {{equals}} implementation. I also corrected a minor Javadoc warning. The test-patch run on HDFS-5260 also reported new javac warnings. These are due to use of internal Sun APIs for {{munmap}}, and there isn't any way for us to suppress them. > ElasticByteBufferPool#Key does not implement equals. > ---------------------------------------------------- > > Key: HDFS-5266 > URL: https://issues.apache.org/jira/browse/HDFS-5266 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Affects Versions: HDFS-4949 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-5266.1.patch > > > {{ElasticByteBufferPool#Key}} does not implement {{equals}}. It's used as a map key, so we should implement this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira