Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 10 Sep 2013 14:26:52 +0000 (UTC)
From: "Tsz Wo (Nicholas), SZE (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12666760.1378243296579.107943.1378823212063@arcas>
In-Reply-To: <JIRA.12666760.1378243296579@arcas>
References: <JIRA.12666760.1378243296579@arcas>
Subject: [jira] [Commented] (HDFS-5157) Datanode should allow choosing the
 target storage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763062#comment-13763062 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-5157:
----------------------------------------------

Thanks Junping.  The patch looks good.  Some minor comments:

- In the FsDatasetImpl constructor, the DataStorage storage parameter is supposed to have the StorgeType information in the future.  The getStorageTypeFromLocations(..) method is a temporary workaround.  Let's put a TODO comment.  (BTW, there is a unnecessary change of {{/**}} around getStorageTypeFromLocations).

- We should remove FsVolumeList.getNextVolume(long).  The callers should always pass StorageType when calling getNextVolume(..).  Let's also put a TODO comment.
                
> Datanode should allow choosing the target storage
> -------------------------------------------------
>
>                 Key: HDFS-5157
>                 URL: https://issues.apache.org/jira/browse/HDFS-5157
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: Heterogeneous Storage (HDFS-2832)
>            Reporter: Arpit Agarwal
>            Assignee: Junping Du
>         Attachments: HDFS-5157-v1.patch
>
>
> Datanode should allow should choosing a target Storage or target Storage Type as a parameter when creating a new block. Currently there are two ways in which the target volume is chosen (via {{VolumeChoosingPolicy#chooseVolume}}.
> # AvailableSpaceVolumeChoosingPolicy
> # RoundRobinVolumeChoosingPolicy
> BlockReceiver and receiveBlock should also accept a new parameter for target storage or storage type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira