hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5266) ElasticByteBufferPool#Key does not implement equals.
Date Fri, 27 Sep 2013 05:25:02 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-5266:
--------------------------------

    Attachment: HDFS-5266.addendum.patch

Right you are, Colin.  Do you mind if I tack an addendum on this issue?

This patch adds {{hashCode}} and also addresses a warning about checking for null in {{equals}}.
 I prefer this over adding suppressions, because even if {{TreeMap}} doesn't call these methods
now, it's possible we could switch data structures, or it's possible that future JDK versions
of {{TreeMap}} will start calling them, and it could be challenging to diagnose.  Can I commit
this?

My local run of Findbugs came back clean, so I expect this is the last of it.
                
> ElasticByteBufferPool#Key does not implement equals.
> ----------------------------------------------------
>
>                 Key: HDFS-5266
>                 URL: https://issues.apache.org/jira/browse/HDFS-5266
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: HDFS-4949
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>             Fix For: HDFS-4949
>
>         Attachments: HDFS-5266.1.patch, HDFS-5266.addendum.patch
>
>
> {{ElasticByteBufferPool#Key}} does not implement {{equals}}.  It's used as a map key,
so we should implement this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message