hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5245) Retry policies should return false rather than rethrow an exception in branch-1
Date Wed, 25 Sep 2013 17:38:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777787#comment-13777787
] 

Jing Zhao commented on HDFS-5245:
---------------------------------

The patch looks good to me. Only one nit: now with the change some shouldRetry methods no
longer throw exception, thus we can remove "throw Exception" from their definition. 

Besides, could you please also post the "ant test" results?

+1 after the above addressed.
                
> Retry policies should return false rather than rethrow an exception in branch-1
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-5245
>                 URL: https://issues.apache.org/jira/browse/HDFS-5245
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5245.000.patch
>
>
> A RetryPolicy inspects the exception generated when performing work and decides to try
the work again.
> In branch-1 a RetryPolicy either returns false or rethrow the exception in the shouldRetry()
function to indicate it decides not to retry. However, rethrowing an exception confuses the
upstream code and causes it to print out excessive warning messages.
> This bug is fixed in trunk and branch-2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message