hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5245) Retry policies should return false rather than rethrow an exception in branch-1
Date Wed, 25 Sep 2013 06:47:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777206#comment-13777206
] 

Haohui Mai commented on HDFS-5245:
----------------------------------

testPatch result:

-1 overall.  

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified tests.
                    Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs.  The patch appears to introduce 223 new Findbugs (version 2.0.2) warnings.

I manually looked into the results of findbugs. The results before and after the patches are
identical, thus the -1 from findbugs might due to a bug in the test script or my configuration
on the test machine.

                
> Retry policies should return false rather than rethrow an exception in branch-1
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-5245
>                 URL: https://issues.apache.org/jira/browse/HDFS-5245
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5245.000.patch
>
>
> A RetryPolicy inspects the exception generated when performing work and decides to try
the work again.
> In branch-1 a RetryPolicy either returns false or rethrow the exception in the shouldRetry()
function to indicate it decides not to retry. However, rethrowing an exception confuses the
upstream code and causes it to print out excessive warning messages.
> This bug is fixed in trunk and branch-2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message