hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinghui Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5244) TestNNStorageRetentionManager#testPurgeMultipleDirs fails because incorrectly expects Hashmap values to have order.
Date Fri, 20 Sep 2013 22:17:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773498#comment-13773498
] 

Jinghui Wang commented on HDFS-5244:
------------------------------------

attached patch to use LinkedHashMap for dirRoots to maintain the order that storages are added.

                
> TestNNStorageRetentionManager#testPurgeMultipleDirs fails because incorrectly expects
Hashmap values to have order. 
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5244
>                 URL: https://issues.apache.org/jira/browse/HDFS-5244
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.1.0-beta
>         Environment: Red Hat Enterprise 6 with Sun Java 1.7 and IBM java 1.6
>            Reporter: Jinghui Wang
>             Fix For: 3.0.0, 2.1.0-beta, 2.1.1-beta
>
>         Attachments: HDFS-5244.patch
>
>
> The test o.a.h.hdfs.server.namenode.TestNNStorageRetentionManager uses a HashMap(dirRoots)
to store the root storages to be mocked for the purging test, which does not have any predictable
order. The directories needs be purged are stored in a LinkedHashSet, which has a predictable
order. So, when the directories get mocked for the test, they could be already out of
> the order that they were added. Thus, the order that the directories were
> actually purged and the order of them being added to the LinkedHashList could
> be different and cause the test to fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message