hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5236) Change PathBasedCacheDirective APIs to be a single value rather than batch API
Date Fri, 20 Sep 2013 23:56:51 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HDFS-5236:
------------------------------

    Attachment: hdfs-5236-1.patch

Patch attached. Included a few other changes too while I was knuckle-deep in the RPC code:

* Removed Fallible and reworked the batch APIs to be single value
* Added wrapper functions in DFSClient to unwrap RemoteExceptions for the client
* Made the various types of exceptions also have a single String value constructor so they
can be remotely unwrapped
* Beefed up the testing in {{TestPathBasedCacheRequests}} to test both NameNodeRpcServer and
DFS APIs, added some additional null/empty string handling in the process.
                
> Change PathBasedCacheDirective APIs to be a single value rather than batch API
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-5236
>                 URL: https://issues.apache.org/jira/browse/HDFS-5236
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: HDFS-4949
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-5236-1.patch
>
>
> It's kind of awkward that APIs like {{addPathBasedCacheDirective}} take a list of Directives
and return a list of Fallibles, since end users don't see a checked exception and need to
check each Fallible. It also complicates HDFS code. Let's think about switching these APIs
to instead take only a single Directive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message