hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5230) Introduce RpcInfo to decouple XDR classes from the RPC API
Date Wed, 25 Sep 2013 20:44:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778052#comment-13778052
] 

Brandon Li commented on HDFS-5230:
----------------------------------

Nice patch!
Some nits: 
1. VerifierGSS.java has no change, please revert it.
2. the changes in Portmap.java doesn't seems to be necessary, please revert it if you agree.
3. As also pointed by Jing, the changes in Verifier.java can be removed.
                
> Introduce RpcInfo to decouple XDR classes from the RPC API
> ----------------------------------------------------------
>
>                 Key: HDFS-5230
>                 URL: https://issues.apache.org/jira/browse/HDFS-5230
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5230.002.patch, HDFS-5230.003.patch
>
>
> The XDR class is one fundamental aspect in the current implementation of NFS server.
While the client might potentially have a higher level APIs, it also requires redundant copying
since the upstream clients have insufficient information.
> This JIRA introduces a new class, RpcInfo, which (1) decouples XDR from the APIs, turning
it into a utility class, and (2) exposes ChannelBuffer directly to the client in order to
open the opportunity for avoid copying.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message