hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5207) In BlockPlacementPolicy, update 2 parameters of chooseTarget()
Date Mon, 16 Sep 2013 10:05:54 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768203#comment-13768203
] 

Junping Du commented on HDFS-5207:
----------------------------------

Thanks for great comments, Nicholas! I addressed them in v3 patch. Please help to take a look
at it again. Thx!
                
> In BlockPlacementPolicy, update 2 parameters of chooseTarget()
> --------------------------------------------------------------
>
>                 Key: HDFS-5207
>                 URL: https://issues.apache.org/jira/browse/HDFS-5207
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HDFS-5207-v1.patch, HDFS-5207-v2.patch, HDFS-5207-v3.patch
>
>
> We should change chooseTarget(..., DatanodeDescriptor writer, ...) to chooseTarget (...,
node writer, ...) as the only important property of writer is to identify other nodes' location
relationship so more generic one could be better. It also helps to cover cases that client
node is not a Datanode. Also, the excluded nodes are not necessary to be a HashMap with the
same key and value, Set is more proper in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message