hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-5201) NativeIO: consolidate getrlimit into NativeIO#getMemlockLimit
Date Fri, 13 Sep 2013 22:20:51 GMT

     [ https://issues.apache.org/jira/browse/HDFS-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-5201:
--------------------------------

    Hadoop Flags: Reviewed

Thanks, Colin.  This looks good.  Just one very minor nit: can you please add a JavaDoc {{@return}}
tag on {{NativeIO#getMemlockLimit}}?

+1 for the patch after that.

                
> NativeIO: consolidate getrlimit into NativeIO#getMemlockLimit
> -------------------------------------------------------------
>
>                 Key: HDFS-5201
>                 URL: https://issues.apache.org/jira/browse/HDFS-5201
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: HDFS-4949
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5201-caching.001.patch
>
>
> Let's consolidate {{NativeIO#POSIX#getrlimit}} into {{NativeIO#getMemlockLimit}}.  This
avoids a few issues with the current function: it is not available on Windows, it relied on
Linux-specific constants, and it currently returns a string which has to be parsed rather
than a long.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message