hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5195) Prevent passing null pointer to mlock and munlock.
Date Fri, 13 Sep 2013 20:39:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766917#comment-13766917
] 

Colin Patrick McCabe commented on HDFS-5195:
--------------------------------------------

+1 for the patch; thanks Chris
                
> Prevent passing null pointer to mlock and munlock.
> --------------------------------------------------
>
>                 Key: HDFS-5195
>                 URL: https://issues.apache.org/jira/browse/HDFS-5195
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: HDFS-4949
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5195.1.patch, HDFS-5195.2.patch
>
>
> According to JNI documentation, it is optional for the JVM to support the {{GetDirectBufferAddress}}
function.  If unsupported, then the function will return null.  This is probably a very rare
thing, but let's be defensive by checking the return value for null and throwing an exception
instead of passing null down to {{mlock}} and {{munlock}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message