hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5192) NameNode may fail to start when dfs.client.test.drop.namenode.response.number is set
Date Fri, 13 Sep 2013 01:57:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766166#comment-13766166
] 

Hadoop QA commented on HDFS-5192:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602909/HDFS-5192.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4962//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4962//console

This message is automatically generated.
                
> NameNode may fail to start when dfs.client.test.drop.namenode.response.number is set
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-5192
>                 URL: https://issues.apache.org/jira/browse/HDFS-5192
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-5192.001.patch, HDFS-5192.002.patch
>
>
> In HDFS-5118 we add a new configuration property "dfs.client.test.drop.namenode.response.number"
for DFSClient, which controls if DFSClient drops RPC responses for testing purpose. 
> Currently this property can only be set in the configuration of the client side (with
HA configuration). If Namenode's configuration sets this property with a positive value, an
IllegalStateException may be thrown (e.g., when starting the trash emptier thread in NN).
This is because NN will overwrite the configuration properties such as fs.defaultFS, when
the trash emptier thread is started and tries to create a DistributedFileSystem instance,
it will find that 1) the drop response property is set with a positive number, and 2) the
given namenode URI is not a logical name (overwritten by NN before).
> A simple fix is to check if we can get a LossyRetryInvocationHandler based proxy in the
constructor of DFSClient. If not, instead of throwing an exception, we can fall back to the
original DFSClient creation process.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message